Correct deprecated methods in PHP7.4 (#1079) #1080
Conversation
* runtime/lib/query/Join.php implode() was used against the definition (wrong PHP documentation * runtime/lib/query/ModelCriteria.php count() was used on non-countable variable (non-array)
michalmagic42
force-pushed
the
michal/1079/correct-deprecated-methods-for-php-7.4
branch
from
489b8cd
to
8b24c58
Compare
|
Would be really great if someone can merge this request! :) |
|
@michalmagic42 , could you please also perform next compatibility changes in scope of your pull request? Replace curly braces with square brackets(https://wiki.php.net/rfc/deprecate_curly_braces_array_access): |
|
Hey everybody just noticed that my project LibreTime is running into this with our attempt to support php 7.4 - anything I can do to help move along the process ? |
Same here! I'm also willing to help |
|
It seems the request is that all of the 7.4 compatibility fixes be done in one PR, not sure if @michalmagic42 is still paying attention to this, if not should somebody open up a new PR to handle those requested by @romantymoshyk as well as the fixes that are this PR ? |
Technically, I cannot find the time to handle changes proposed by @romantymoshyk |
|
I opened up a new PR that fixes the curly brace changes that were requested above by @romantymoshyk , so hopefully they can both be merged or else combined (if that is desired by the maintainers). Let me know if there is anything else I can do to help. |
@Robbt your PR failed on checking. Please correct the PR, otherwise, there is no chance to have the PR merged. |
|
I made a lot of effort within my PR to have everything running with PHP7.4 also modernizing the stack (phpunit etc.) to work inside of our migrated to php7.4 project. #1086 |
|
Any updates on this one? Can I help to get this PR merged? |
I did all the heavy lifting for PHP7.4 in #1086 if you want to help then please have a look there |
|
heads up that hostmonster just pushed php7.4 as the default on maybe everyone, its cPanel overriding a manual php version pinning which I had set in .htaccess with its own later addhandler specification_ ಠ_ಠ, which led to my site not loading, eventually leading me to this github issue. I eventually fumbled my way to the cPanel "Programming > PHP Config" area, where I could (re)set my own default, down to 7.3, which removes the addhandler that they had added, so I don't think it will get magically re-added again 🤞 |
runtime/lib/query/Join.phpimplode()was used against the definition (wrong PHP documentationruntime/lib/query/ModelCriteria.phpcount()was used on non-countable variable (non-array)